Code review comment for lp:~sinzui/launchpad/launchapd-apocalypse-1

This is my branch to move the hwdb to lp, the first of many branches to
complete the lp code migration.

    reviewer: adeuring

    lp:~sinzui/launchpad/launchapd-apocalypse-1
    Diff size: 1381
    Launchpad bug: https://bugs.launchpad.net/bugs/launchapd-apocalypse-1
    Test command: ./bin/test -vv -t hardwaredb.* -t bugs.*doc/bug.txt
    Pre-implementation: deryck
    Target release: 10.02

Move the hwdb to lp
-------------------

Use the migrater script to move the hwdb classes to the new lp.hardwaredb.

Rules
-----

    * Use the migrater to move the hwdb to the lp tree.
    * Hush lint if it complains.

QA
--

As this is a refactoring, a few sport checks are needed to verify that
the feature is fine:

    * View https://edge.launchpad.net/~sinzui/+hwdb-submissions
    * Verify the page lists.
    * Verify the system link works.

Lint
----

Linting changed files:
  cronscripts/process-hwdb-submissions.py
  lib/canonical/launchpad/configure.zcml
  lib/canonical/launchpad/security.py
  lib/canonical/launchpad/systemhomes.py
  lib/canonical/launchpad/browser/__init__.py
  lib/canonical/launchpad/browser/launchpad.py
  lib/canonical/launchpad/ftests/test_system_documentation.py
  lib/canonical/launchpad/interfaces/__init__.py
  lib/canonical/launchpad/interfaces/_schema_circular_imports.py
  lib/canonical/launchpad/scripts/garbo.py
  lib/canonical/launchpad/scripts/tests/test_hwdb_submission_parser.py
  lib/canonical/launchpad/scripts/tests/test_hwdb_submission_processing.py
  lib/canonical/launchpad/zcml/configure.zcml
  lib/lp/hardwaredb/
  lib/lp/bugs/browser/bugtarget.py
  lib/lp/bugs/doc/bug.txt
  lib/lp/bugs/doc/bugtask-search.txt
  lib/lp/bugs/model/bug.py
  lib/lp/bugs/model/bugtask.py
  lib/lp/bugs/tests/test_bugtask.py
  lib/lp/hardwaredb/__init__.py
  lib/lp/hardwaredb/browser/
  lib/lp/hardwaredb/configure.zcml
  lib/lp/hardwaredb/doc/
  lib/lp/hardwaredb/interfaces/
  lib/lp/hardwaredb/model/
  lib/lp/hardwaredb/scripts/
  lib/lp/hardwaredb/stories/
  lib/lp/hardwaredb/templates/
  lib/lp/hardwaredb/tests/
  lib/lp/hardwaredb/browser/__init__.py
  lib/lp/hardwaredb/browser/configure.zcml
  lib/lp/hardwaredb/browser/hwdb.py
  lib/lp/hardwaredb/browser/tests/
  lib/lp/hardwaredb/browser/tests/__init__.py
  lib/lp/hardwaredb/browser/tests/test_views.py
  lib/lp/hardwaredb/doc/__init__.py
  lib/lp/hardwaredb/doc/hwdb-access.txt
  lib/lp/hardwaredb/doc/hwdb-device-tables.txt
  lib/lp/hardwaredb/doc/hwdb-submission.txt
  lib/lp/hardwaredb/doc/hwdb.txt
  lib/lp/hardwaredb/interfaces/__init__.py
  lib/lp/hardwaredb/model/__init__.py
  lib/lp/hardwaredb/model/hwdb.py
  lib/lp/hardwaredb/scripts/__init__.py
  lib/lp/hardwaredb/scripts/hwdbsubmissions.py
  lib/lp/hardwaredb/scripts/tests/
  lib/lp/hardwaredb/scripts/tests/test_hwdb_submission_validation.py
  lib/lp/hardwaredb/stories/__init__.py
  lib/lp/hardwaredb/stories/hwdb/
  lib/lp/hardwaredb/stories/webservice/
  lib/lp/hardwaredb/stories/webservice/xx-hwdb.txt
  lib/lp/hardwaredb/templates/__init__.py
  lib/lp/hardwaredb/tests/__init__.py
  lib/lp/hardwaredb/tests/test_doc.py
  lib/lp/registry/model/person.py
  lib/lp/scripts/utilities/sanitizedb.py
  lib/lp/testing/factory.py
  utilities/migrater/migrater.py

Test
----

This is a refactoring. No functionality was changed, the existing tests
run

Implementation
--------------

This is a mechanical refactoring performed by the migrator script. Some
imports and white space fixes were made as reported by lint.
Describe what is expected to change and how.

--
__Curtis C. Hovey_________
http://launchpad.net/