Code review comment for lp:~sinzui/launchpad/launchapd-apocalypse-1

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Thanks for your continued effort to push our codebase forward! Lots of little drive-bys in addition to mechanical changes.

Two minor things we discussed on IRC:
 * Trailing comma at the end of an arguments list.
 * A "try: ... except: pass" block in the migrater may or may not be removed, but needs at least an explanation to help the next coder who hits problems there. Either way is alright with me in this case.

Jeroen

review: Approve

« Back to merge proposal