Code review comment for lp:~sinzui/launchpad/launchpad-header-0

Revision history for this message
Curtis Hovey (sinzui) wrote :

These are the three headers Michael and I looked at. They represent the best and worst of how the header works. In all cases the space before the logo and the space without bread crumbs is fixed \o/. The title edit widget hold together since it does not need to dodge the left and right content. By aligning the primary context title and apps with the bottom of the logo, view.png shows what we wanted users to see. But the two context images have a registration line that inserts a blank line. Registration always did this, it was not as obvious.

http://people.canonical.com/~curtis/primary-context.png
http://people.canonical.com/~curtis/title-edit-widget.png
http://people.canonical.com/~curtis/view.png
http://people.canonical.com/~curtis/secondary-context.png

I ponder moving the registation before or after the bread crumbs. We want the registration to be adjacent to the title of the context. This was/is not possible for primary contexts. We rely on the sparceness of the header to imply that the context is the only thing the registration text can pertain to. Placing the registration before the breadcrumbs, a, returns to the orginal design for 3.0, and b, puts the information closer to the primary context logo, and the secondary context title when it exists.

/me hacks to make screen caps.

« Back to merge proposal