Code review comment for lp:~sinzui/launchpad/launchpad-header-0

Revision history for this message
Curtis Hovey (sinzui) wrote :

I moved the registration slot into context-location area, it it between the context title and bread crumbs. I made the text the same size as the bread crumbs.

http://people.canonical.com/~curtis/better-primary-context.png
http://people.canonical.com/~curtis/better-title-edit.png
http://people.canonical.com/~curtis/better-view.png
http://people.canonical.com/~curtis/better-secondary-context.png

These changes did not inflate the diff. I updated a test to verify the content moved.

The bug page did look bad, and that is because it violates the registration slot rules...the
data is immutable; it is not a status. I moved the heat inline and updated the one affected
test. Another was robust. I removed the redundant bug number too (no tests broke).
./bin/test -vvc -t bug-heat-view -t xx-bug-heat-on-bug-page

« Back to merge proposal