Code review comment for lp:~sinzui/launchpad/package-link-validation

This is my first branch to ensure valid upstream package links. There
are many oopses relating to the creation and efforts to fix invalid packages.
The root cause is a bad DB constraint and two views that do not do the
required sanity checks: +addPackage and +ubuntupkg

This branch is a set of mechanical changed made by the migrater script to
move packaging from canonical.launchpad to lp.registry

    lp:~sinzui/launchpad/package-link-validation
    Diff size: 395
    Launchpad bug: https://bugs.launchpad.net/bugs/453212
    Test command: ./bin/test -vv -t test_packaging \
                                 -t stories/packaging
    Pre-implementation: flacoste
    Target release: 3.1.10

== Rules ==

    * Run th migrator to take ownership of the problem code.

== QA ==

    * Visit any productseries that you are the owner or release manager of
    * Choose (+) Add package
    * Verify the page displays a for to choose a distroseries and source
      package.

== Lint ==

Linting changed files:
  lib/canonical/launchpad/security.py
  lib/canonical/launchpad/browser/__init__.py
  lib/canonical/launchpad/database/__init__.py
  lib/canonical/launchpad/interfaces/__init__.py
  lib/canonical/launchpad/zcml/configure.zcml
  lib/lp/registry/configure.zcml
  lib/lp/registry/browser/configure.zcml
  lib/lp/registry/browser/distributionsourcepackage.py
  lib/lp/registry/browser/packaging.py
  lib/lp/registry/browser/sourcepackage.py
  lib/lp/registry/browser/tests/test_packaging.py
  lib/lp/registry/browser/tests/test_person_view.py
  lib/lp/registry/model/distribution.py
  lib/lp/registry/model/distroseries.py
  lib/lp/registry/model/packaging.py
  lib/lp/registry/model/product.py
  lib/lp/registry/model/productseries.py
  lib/lp/registry/model/sourcepackage.py
  lib/lp/registry/stories/packaging/
  lib/lp/registry/tests/test_packaging.py
  utilities/migrater/migrater.py

== Test ==

No tests changed. The three migrated tests do work.

== Implementation ==

    * utilities/migrater/migrater.py
      Fixed errors that were committed some time ago.