Code review comment for lp:~sinzui/launchpad/prf-files

Revision history for this message
Curtis Hovey (sinzui) wrote :

> This looks fine, except line 45 of the patch, which looks like it shouldn't be
> there.

I Removed the extra line. PEP8.py also reported that another test was missing a blank line.

=== modified file 'lib/lp/registry/tests/test_prf_finder.py'
--- lib/lp/registry/tests/test_prf_finder.py 2009-11-02 17:35:34 +0000
+++ lib/lp/registry/tests/test_prf_finder.py 2009-11-02 19:42:51 +0000
@@ -102,6 +102,7 @@
     def test_handleProduct(self):
         # test that handleProduct() correctly calls handleRelease()
         class DummyProductReleaseFinder(ProductReleaseFinder):
+
             def __init__(self, ztm, log):
                 ProductReleaseFinder.__init__(self, ztm, log)
                 self.seen_releases = []
@@ -174,7 +175,6 @@
         shutil.rmtree(self.release_root, ignore_errors=True)
         reset_logging()

-
     def test_handleRelease(self):
         ztm = self.layer.txn
         logging.basicConfig(level=logging.CRITICAL)

« Back to merge proposal