Code review comment for lp:~sinzui/launchpad/source-package-ui

This is my branch to update the last source package pages to UI 3.0.

    lp:~sinzui/launchpad/source-package-ui
    Diff size: 651
    Launchpad bug: https://bugs.launchpad.net/bugs/429020
    Test command: ./bin/test -vv \
        -t question-add.txt \
        -t xx-sourcepackage-packaging.txt \
        -t xx-distroseries-sources
    Pre-implementation: no one
    Target release: 3.1.0

= Update the last source package pages to UI 3.0 =

sourcepackage-gethelp.pt
    * Move the template to answers. Update it to 3.0.

sourcepackage-packaging.pt
    * Linkify the items in the table so that the portlets are not needed.
    * Update the page to UI 3.0

sourcepackage-index.pt
    * Move the details portlet to the top of the first column, Move Upstream
      associations to the top right column.
    * Move Releases in Ubuntu and Upstream release series inline.
    * Move Changelog, Show builds, and Show upstream links into content
    * Change upstream link and Set upstream link are identical; merge them.
    * I considered the moving the download files to the side portlets, but
      their purpose is not really for users, be developers, so I think they
      belong on the content.

== QA ==

Compare
    http://people.canonical.com/~curtis/sourcepackage.png
With
    https://edge.launchpad.net/ubuntu/karmic/+source/alsa-utils

== Lint ==

Linting changed files:
  lib/canonical/launchpad/pagetitles.py
  lib/lp/answers/stories/question-add.txt
  lib/lp/answers/templates/sourcepackage-gethelp.pt
  lib/lp/registry/browser/configure.zcml
  lib/lp/registry/browser/sourcepackage.py
  lib/lp/registry/templates/sourcepackage-index.pt
  lib/lp/registry/templates/sourcepackage-packaging.pt
  lib/lp/registry/templates/sourcepackage-portlet-details.pt
  lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt

== Test ==

    * lib/lp/answers/stories/question-add.txt
      * Added a test to verify that the breadcrumb shows up in the page title.
        This is a known issue that Salgado has a fix for. It is out of scope
        for this branch.
      * Updated test to show the page uses the standard link.
    * lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt
      * Updated brittle test.

== Implementation ==

    * lib/canonical/launchpad/pagetitles.py
      * Removed unused page titles.
    * lib/lp/answers/templates/sourcepackage-gethelp.pt
      * Moved page to answers.
      * Updated the page to 3.0
      * Switched to standard links.
    * lib/lp/registry/browser/configure.zcml
      * Updated config to use the template from the lp/ansers
      * Registered +packaging as its own view.
    * lib/lp/registry/browser/sourcepackage.py
      * Added SourcePackageHelpView and SourcePackagePackaging to provide
        unique heading and titles to the pages.
    * lib/lp/registry/templates/sourcepackage-index.pt
      * Moved a lot of content around, and changed a many <ul> in <dl>.
        But as you can see from the one test change, the content has not
        changed at all. If the one test was not checking markup, there would
        have been no failures.
      * See the picture if you do not want to run the server.
    * lib/lp/registry/templates/sourcepackage-packaging.pt
      * Updated the page to 3.0. Linked the distro and series so that the
        portlet was not needed to get to them.
    * lib/lp/registry/templates/sourcepackage-portlet-details.pt
      * Updated the portlet to 3.0 style.