Code review comment for lp:~sinzui/launchpad/spam-eggs-bug-495250

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 15.12.2009 00:00, Curtis Hovey schrieb:
> Curtis Hovey has proposed merging lp:~sinzui/launchpad/spam-eggs-bug-495250 into lp:launchpad/devel.

> This is my branch to discourage spammers.

Yeah! Cool stuff! Thanks for the quick and smart fix.

 review approve

All I found was a little glitch in a comment...

> === modified file 'lib/lp/registry/browser/person.py'

Straightforward implementation, clear comments, good code. ;)

> === modified file 'lib/lp/registry/browser/tests/person-views.txt'
> --- lib/lp/registry/browser/tests/person-views.txt 2009-11-20 18:44:57 +0000
> +++ lib/lp/registry/browser/tests/person-views.txt 2009-12-14 23:00:33 +0000
> @@ -4,7 +4,127 @@
> person's information.
>
>
> -== Email address disclosure ==
> +Probationary and invalid users
> +------------------------------
> +
> +The person +index view provides the is_probationary_or_invalid_user so that
> +page features can be disabled because the user may abuse them. Active
> +users with karma are not on probation. The user's homepage_content formatted
> +as HTML

Add an "is" and a ".", please. ;)

[...]

> === modified file 'lib/lp/registry/templates/person-index.pt'
As expected.

> === modified file 'lib/lp/testing/views.py'
Thanks for the drive-by fix.

Cheers,
Henning

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksnW2cACgkQBT3oW1L17iigywCcDytaSGCqRg0vliB5hMTqAOT0
x7IAn2Pb+6N0J+kAeoBbYvvltNGPfxnV
=qBEM
-----END PGP SIGNATURE-----