Code review comment for lp:~smspillaz/compiz-core/compiz-core.tests_915950

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

This *looks* OK, but like Daniel says it looks like several (sequential) changes overlayed on each other which makes it hard to validate.

I'd prefer to see separate commits for refactoring (moving/renaming stuff) and functional changes (making it work). (But I'm as guilty of mixing the two.)

review: Approve

« Back to merge proposal