Bazaar

Code review comment for lp:~songofacandy/bzr/fix-523746-2

  1. fix-523746-2
  2. Merge into 2.0
Revision history for this message
Martin Packman (gz) wrote :

Ack, was that big a follow up needed? I only intended to suggest something like:

- full_path = osutils.pathjoin(self._root, prefix, relpath)
+ full_path = osutils.pathjoin(self._root, prefix, relpath.encode(
+ sys.getfilesystemencoding() or 'ascii', 'replace').replace(
+ "?", "_"))

The new encoding-then-decoding seems redundant, as do the changes in `_get_command`, what prompted you to add that when the last version was so simple?

« Back to merge proposal