Code review comment for lp:~songofacandy/bzr/fix-523746-2

Revision history for this message
Martin Packman (gz) wrote :

> But I doesn't like depending character mapping.
> I think encoded string is magic bytes and modifying it is dangerous.

Yeah, fair enough. Perhaps dealing with this just for tempfiles is too much and sticking to ascii-only for the mangling is the best choice.

« Back to merge proposal