Code review comment for lp:~songofacandy/bzr/fix-523746-2

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin [gz] wrote:
> Ack, was that big a follow up needed? I only intended to suggest something like:
>
> - full_path = osutils.pathjoin(self._root, prefix, relpath)
> + full_path = osutils.pathjoin(self._root, prefix, relpath.encode(
> + sys.getfilesystemencoding() or 'ascii', 'replace').replace(
> + "?", "_"))

^- This should probably be 'osutils._fs_enc' where we already handle fs
encoding of None.

>
> The new encoding-then-decoding seems redundant, as do the changes in `_get_command`, what prompted you to add that when the last version was so simple?

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuH3lsACgkQJdeBCYSNAANLJACgvw/A8y0EKW4chN31ewdmof2r
oqoAn3NAsSjyZ7vcvcdL6sOLKEjgg2Tq
=eWJM
-----END PGP SIGNATURE-----