Code review comment for lp:~songofacandy/bzr/fix-523746-dev

Oh, silly me, I mis-read your initial comment as pointing to itself,
where in fact, you just did what I asked in the *other* mp.

Anyway, this illustrates why I find sparse branch names unhelpful, I just didn't
recognize it :)

In fact you made the comments I was waiting for on the other mp:

> This problem depends on OS, locale settings and other environment.
> So I agree with you that this patch should land to bzr.dev and be tested on
> vary environment while bzr 2.2 is released.

Fine, I'll mark the other mp rejected.

So, test against variations on locale settings exist in bzrlib/tests/test_non_ascii.py
and bzrlib/tests/blackbox/test_non_ascii.py

Ask for help if you don't find the existing tests enough to write your own.