Bazaar

Code review comment for lp:~songofacandy/bzr/fix-523746-dev

  1. fix-523746-dev
  2. Merge into bzr.dev
Revision history for this message
Vincent Ladeuil (vila) wrote :

So it appears that I lack the windows knowledge (and the ability to tests)
to effectively help Naoki here.

The consensus seems to be that the problem is now to either:
- make subprocess.Popen accept unicode arguments (Naoki as a monkey-patch for that
  but I find it a bit scary),
- bypass subprocess.Popen and use a direct win32 API (I'm out of my league on
  this one)

John ? Alexander ? Can you give it a try ?

review: Abstain

« Back to merge proposal