Code review comment for lp:~songofacandy/bzr/i18n

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

...
> This is not a real issue, just a cosmetic one.
>
> The feedback I get is that developers prefer writing the shorter _() to a translatable message than the longer and perhaps less readable gettext(). This has been the standard practice for nearly all localizable Open Source projects I've seen. The only exception that I can think of off the top of my head is bzr-gtk, where i18n() is used.
>
> Why is is an issue in bzr but not in all other Python projects that make use of gettext?

Because developers (such as myself) have a higher tendency to break into
the debugger in the middle of an active session (because we trap SIGQUIT
to do just that), and once you have done so _() breaks all future
running of the program because the builtin _() gets overridden.

Going further, I don't think bzr directly gains by putting i18n around
the code base. We generally *don't* want to be handing around translated
strings. We just want to translate at the point we display to the user
(as much as possible).

Also, why write _() in your code everywhere when there are very
deterministic locations where translatable strings reside. (Such as
Command.__doc__.)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3JJdsACgkQJdeBCYSNAAO4HgCgw+pdJVwBXHySlLUIaPCTSYBt
u8QAn3jS+r2QP7di9ZM+RmTmZX5b7jey
=9APd
-----END PGP SIGNATURE-----

« Back to merge proposal