Code review comment for lp:~soren/nova/raw-disk-images

Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

Hi Soren,

I checked out your code, and I am not able to launch raw images through the EC2 api.
When I use ' --kernel nokernel', I get the following error:
ERROR:root:NotFound: Image nokernel could not be found

I believe this happens because the image service still tries to retrieve the kernel image.
from compute/api.py lines 86-87:
            if kernel_id:
                self.image_service.show(context, kernel_id)

In the original branch from justinsb, kernel and ramdisk images were not retrieve when the null_kernel 'magic number' was used.

            if kernel_id == str(FLAGS.null_kernel):
                kernel_id = None
                ramdisk_id = None
                logging.debug("Creating a raw instance")
            # Make sure we have access to kernel and ramdisk (if not raw)
            if kernel_id:
                image_service.show(context, kernel_id)
            if ramdisk_id:
                image_service.show(context, ramdisk_id)

Is there something I'm not seeing at the moment, or do we need to fix compute/api.py?

review: Needs Information

« Back to merge proposal