Code review comment for lp:~spiv/bzr-pqm/non-local-submission

Revision history for this message
Andrew Bennetts (spiv) wrote :

This could be better, especially in some of the error handling, but it allows me to pqm-submit branches without downloading them.

It adds a --ignore-local option which will skip opening the local branch/tree, and associated checks. In this case it will try looking up the config options (pqm_email etc) from the locations.conf for the public location (which must be given on the command line), and failing that will try the global conf. So e.g. I now have a [http://bazaar.launchpad.net/~*/bzr/] section in my locations.conf to specify the pqm_email.

Probably the StackedConfig class belongs in some form in bzrlib proper (at the moment BranchConfig does something similar but in a less reusable way).

Anyway, this is functional, despite the rough corners.

« Back to merge proposal