Code review comment for lp:~spiv/bzr/i-hate-signals

Revision history for this message
Martin Packman (gz) wrote :

Okay, been through this, the upstream bug, and the signal module C code.
Diagnosis looks fine, as does the proposed patch to the C signal handler in the Python source, would be good to get that landed.

One thing I'm not clear on is how effective the workaround in this merge will be. As the Python handler won't run till the IO function returns, and we've prevented it returning early, there can (and in common cases will be) whole seconds elapsed before say, `sock.read(65536)` completes. Do window managers fire multiple SIGWINCHes if a terminal emulator is dragged wider, or do they tend to wait for the release?

review: Needs Information

« Back to merge proposal