Code review comment for lp:~spiv/bzr/per-file-merge-hook-491711

Revision history for this message
Robert Collins (lifeless) wrote :

On Mon, 2010-01-18 at 11:06 +0000, Andrew Bennetts wrote:

> > AIUI, this is gc'ed when no more references exist on the cached
> > value. It's not obvious and may be worth documenting.
>
> Erk, this is totally bogus. I'm not sure what I was thinking! I was
> trying for a limited quick & dirty cachedproperty decorator without the
> complexity of the one in Launchpad, but I think I should just borrow
> Launchpad's, so I've now done that (including arranging for its doctests
> to be run).

You'll need to get an ack to rerelease the LP code to do this: Launchpad
is AGPL, which is incompatible with GPL.

I agree with John that we need to avoid processing branch.conf per-file.

-Rob

« Back to merge proposal