Code review comment for lp:~spiv/bzr/per-file-merge-hook-491711

Revision history for this message
Vincent Ladeuil (vila) wrote :

> On Mon, 2010-01-18 at 11:06 +0000, Andrew Bennetts wrote:
>

> You'll need to get an ack to rerelease the LP code to do this: Launchpad
> is AGPL, which is incompatible with GPL.

I've got the ack from flacoste.

>
> I agree with John that we need to avoid processing branch.conf per-file.

spiv proposed to cache the config in the plugin, I'll tweak and merge.

We may want to discuss caching the config in the branch itself
(I can't find scenarios where a locked branch could have trouble with that)
but that's outside the scope of this plugin.

« Back to merge proposal