Code review comment for lp:~spiv/bzr/sigwinch-without-signalmodule-583941

On 24 May 2010 16:02, Andrew Bennetts <email address hidden> wrote:

> However, we want to get notified when the terminal size changes, which means either asking the OS every time we want to know the terminal size (perhaps not so bad?), or side-stepping the 'signal' module in Python.  This patch takes the latter route.

Perhaps we should try the former route? (I'm kind of sorry to say
that after you've already done this, but on the other hand history
suggests this may not be the final fix, and it's not all that small.)

I suppose the only drawback is that it may slow us down if we do it
really often. On the other hand I think the progress code already
tries to throttle updates to some extent. Could you try something
with timeit to see just how expensive it would be?