Code review comment for lp:~spiv/bzr/sigwinch-without-signalmodule-583941

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bennetts wrote:
> Andrew Bennetts has proposed merging lp:~spiv/bzr/sigwinch-without-signalmodule-583941 into lp:bzr/2.1.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> #583941 program crashes with "bzr: ERROR: socket.error: (4, 'Interrupted system call')"
> https://bugs.launchpad.net/bugs/583941
>
>
> EINTR, round 99. I believe that this should fix most if not all occurrences of EINTR with the 'bzr' command.

I didn't read the code, but could you do what you need with ctypes
instead of writing a custom extension?

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkv60msACgkQJdeBCYSNAAOBcwCgiEu1w5yM84ZMz3KOPOPMtaHK
n8kAn0Ck0oV5ArHCRMYcVOMUgxF0Mz+N
=JN1C
-----END PGP SIGNATURE-----

« Back to merge proposal