Code review comment for lp:~spiv/loggerhead/shared-repo-fix

Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

I can confirm that this fixes the bug, but I don't actually know the wsgi code, so I'm loath to merge it without input from someone else.

Questions:

1.) Why add loggerhead.path_info? You can just pass 'PATH_INFO' to RelpathSetter, no?

2.) It's interesting that the old code didn't use get_transport_for_thread(), but the new code does. Is it unnecessary, or was the old code broken? (ISTM the change is correct, but I don't want to page threading-related memories into my brain. :P )

review: Approve

« Back to merge proposal