Code review comment for lp:~statik/python-distutils-extra/modernize

Revision history for this message
Elliot Murphy (statik) wrote :

This branch changes some of the defaults in python-mkdebian. Maybe you will hate this idea, maybe it's good. I know defaults can be controversial, but I believe these changes are good defaults for someone who doesn't know a lot about debian packaging who just wants to turn a python module into a debian package.

I changed from python-central to python-support for consistency with debian python packaging team preference for python-support, to make it easier to move packages that are created with this tool upstream into debian.

I move from CDBS to DH7 because I really like what Joey has done in dh7 and how simple the overrides are. For context, look at slide 44 and 45 of http://kitenet.net/~joey/talks/debhelper/debhelper-slides.odp

I pass --buildsystem=python_distutils so that packages work even if there is a makefile in the root (I and some other upstreams like having a makefile with a check command even for a python project). I am not 100% confident whether dh7 takes care of everything that /usr/share/cdbs/1/rules/langpack.mk was handling.

Update to compat level 7.

Update to Standards-Version: 3.8.3

Finally I fix a typo that caused additional_dependencies defaulting to None instead of []

« Back to merge proposal