Code review comment for lp:~statik/python-distutils-extra/modernize

Revision history for this message
Martin Pitt (pitti) wrote :

Elliot,

thanks for the update. Some remarks:

 * I deliberately used DH 6, so that people could use quickly and p-d-e on Hardy (which does not have DH 7 yet). Doing this move is fine after lucid released and is out in the wild for a while.

 * If we ever get applications which got packaged that way into Ubuntu main, we need to change the packaging back to cdbs, since dh7 knows nothing about our i18n infrastructure (such as adding the gettext domain to .desktop files, stripping translations from gconf schemas, and so on). So for now I'd prefer to stick with CDBS.

I'm fine with the move to pysupport, and of course bumping the standards-version. Also, thanks for the typo fix.

review: Needs Fixing

« Back to merge proposal