Code review comment for lp:~statik/ubuntu/karmic/couchdb/fix-bug427036

Revision history for this message
Elliot Murphy (statik) wrote :

Thanks for the quick review!

> Most packages that use this default to starting the daemon.
>
> pulseaudio doesn't because Ubuntu's default set-up uses a per-user setup,
> and fetchmail is often used in the same way.

Neither does fetchmail or monit, which are the other two packages we looked at two get an idea of existing common practice.

>
> Granted you are doing this because you use couchdb in a similar way, but
> it's still a system db on it's own, and that's currently how most people
> use it.
>
> Therefore I am a little wary of this change, but not against it. 2 questions:
>
> 1) I thought the plan was to have a couchdb-bin package to avoid exactly
> this sort of issue.

I've discussed creating a separate couchdb-server binary package that contains only the init script, yes. However I didn't find any example of another package that was structured this way, while John showed me several packages that were using the variable-in-config-file approach. Also, splitting out the separate couchdb-server binary package for the init script would require making changes in the packages that depend on couchdb, which current only seems to be chef-server.

So I'm not opposed to going back and redoing this fix by creating a separate binary package for the init script, but this seemed like a better and simpler way to fix the problem.

> 2) Have you spoken to the Debian maintainer about this?

The init scripts are actually shipped by upstream, and I've submitted the patch to couchdb: https://issues.apache.org/jira/browse/COUCHDB-499

Considering this, what approach do you want to take? If you are convinced that splitting the init script really is the preferable solution, I'm willing to go back and do the change that way.

« Back to merge proposal