Code review comment for lp:~stefanor/ibid/dict-344255

Revision history for this message
Stefano Rivera (stefanor) wrote :

> The dict server won't necessarily be on localhost, so we can't assume that.
> I'm happy with this fix for now though.

No, we can't assume that. But it is quite likely.

The dictclient library doesn't provide a clean close() function, so this does leave connections floating around. The garbage collector will obviously clean them up at some point, although we could do connection.sock.close() (from reading the code).

The alternative of keeping the persistent connection open and doing a reconnect if it's stalled is possible, but I don't think it's worth the effort.

> Why are connection errors caught though? They aren't in other plugins which use the network.

True, bad ibid style.

/me Fixes...

« Back to merge proposal