Merge lp:~stefanor/ibid/manhole-disconnect into lp:~ibid-core/ibid/old-trunk-pack-0.92

Proposed by Stefano Rivera
Status: Merged
Approved by: Stefano Rivera
Approved revision: 675
Merged at revision: 679
Proposed branch: lp:~stefanor/ibid/manhole-disconnect
Merge into: lp:~ibid-core/ibid/old-trunk-pack-0.92
Diff against target: None lines
To merge this branch: bzr merge lp:~stefanor/ibid/manhole-disconnect
Reviewer Review Type Date Requested Status
Michael Gorven Approve
Jonathan Hitchcock Approve
Review via email: mp+7973@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jonathan Hitchcock (vhata) :
review: Approve
Revision history for this message
Michael Gorven (mgorven) wrote :

 review approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ibid/source/manhole.py'
--- ibid/source/manhole.py 2009-05-31 08:10:44 +0000
+++ ibid/source/manhole.py 2009-06-27 22:55:51 +0000
@@ -18,11 +18,16 @@
1818
19 def setServiceParent(self, service=None):19 def setServiceParent(self, service=None):
20 if service:20 if service:
21 return internet.TCPServer(self.port, ShellFactory()).setServiceParent(service)21 self.listener = internet.TCPServer(self.port, self).setServiceParent(service)
22 return self.listener
22 else:23 else:
23 reactor.listenTCP(self.port, self)24 self.listener = reactor.listenTCP(self.port, self)
24 25
25 def connect(self):26 def connect(self):
26 return self.setServiceParent(None)27 return self.setServiceParent(None)
2728
29 def disconnect(self):
30 self.listener.stopListening()
31 return True
32
28# vi: set et sta sw=4 ts=4:33# vi: set et sta sw=4 ts=4:
2934
=== modified file 'ibid/source/telnet.py'
--- ibid/source/telnet.py 2009-06-20 22:50:43 +0000
+++ ibid/source/telnet.py 2009-06-27 22:56:41 +0000
@@ -7,6 +7,7 @@
7import ibid7import ibid
8from ibid.source import IbidSourceFactory8from ibid.source import IbidSourceFactory
9from ibid.event import Event9from ibid.event import Event
10from ibid.config import IntOption
1011
11class TelnetProtocol(telnet.StatefulTelnetProtocol):12class TelnetProtocol(telnet.StatefulTelnetProtocol):
1213
@@ -45,7 +46,7 @@
45class SourceFactory(protocol.ServerFactory, IbidSourceFactory):46class SourceFactory(protocol.ServerFactory, IbidSourceFactory):
46 protocol = TelnetProtocol47 protocol = TelnetProtocol
4748
48 port = 300049 port = IntOption('port', 'Port number to listen on', 3000)
4950
50 def __init__(self, name, *args, **kwargs):51 def __init__(self, name, *args, **kwargs):
51 #protocol.ServerFactory.__init__(self, *args, **kwargs)52 #protocol.ServerFactory.__init__(self, *args, **kwargs)

Subscribers

People subscribed via source and target branches