Code review comment for lp:~stefanor/ibid/manpages-510020

Revision history for this message
Stefano Rivera (stefanor) wrote :

> Can ibid.ini not be located in /etc ?

If you have a single machine-wide Ibid, yes it can. However that's more of a packaging question. At the moment, we aren't doing anything about that kind of thing.
See http://svn.debian.org/viewsvn/python-apps/packages/ibid/trunk/debian/README.Debian?view=markup

> Should this really be under "BUGS"?

Well, it is a bug that it misses those massages, yes. I could rephrase it to say that. r880

> How about adding that this can be achieved by running "twistd -n ibid"?

Yeah. r880

> > ibid(1), ibid.ini(5), ibid-setup(1), http://ibid.omnia.za.net/
> This is in ibid.1. Should it really be referencing what I believe is itself?

Correct. r881

> > A complete description of the contents of this file is out of the scope of
> > this man‐page, for more details see the Ibid documentation.
> Break up into 2 sentences.

Done. r882

> Maybe mention that when automatically written to, the bot will preserve manual
> edits.

r883

> Weren't there some bugs associated with "reload config" not fully working?
> Perhaps mention them under a BUGS section.

No, I think they were fixed.

> I don't like how tha man page splits auth.permissions over multiple lines. Is
> there a way to force it to keep it on a single line?

Yes, one can tell it not to hyphenate specific words. File a bug for 0.2, if you want ot do that to all of them :)

> > Plugin configuration, each plugin is configured within a section named after
> I don't like that comma. Maybe a colon? There are also other places where this
> occurs.

r884

> > SEE ALSO
> > ibid(1), ibid-objgraph(1), http://ibid.omnia.za.net/
> This is in ibid-objgraph.1. I guess that ibid-objgraph(1) should have been
> ibid-memgraph(1)

r885

> > This utility is passing events to a running Ibid bot, or executing RPC-
> exposed functions remotely.
> This utility is *for* passing

r886

> > ibid-plugin.1 BUGS
> It also doesn't emulate accounts/identities.

Well spotted. r887

> > ibid-setup - Create a configuration file and Database for an Ibid bot
> Create a *basic* configuration file and *d*atabase as a starting point for an
> Ibid bot

Not mad about "starting point". r888

> > This program installs a new Ibid bot.
> Does it really *install* the bot? When I read install, I think it does more
> than what this script does. Maybe "configures"?

r889

« Back to merge proposal