Code review comment for lp:~stefanor/ibid/memory-logging

Revision history for this message
Michael Gorven (mgorven) wrote :

I would have tried to use Python logging's rotating logfiles instead of doing
it manually, but since you've already implemented this it's fine. I think
that the logging processor should have autoload=False though, so that it has
to be explicitly enabled.
 review approve

review: Approve

« Back to merge proposal