Code review comment for lp:~stefanor/ibid/translation-334764

Revision history for this message
Stefano Rivera (stefanor) wrote :

My take on https://code.edge.launchpad.net/~bradwhittington/ibid/translation/+merge/3962

While I was at it, I tweaked a few responses.

Note, if you want to call addresponse with an arbitrary string, you now have to use addresponse(u'%s', string). We could work around this, by checking if len(attrs) > 0, but I think the way it is will promote good response style.

Also note, addresponse will only format unicode strings. Again, we could work around this, but I don't know if that's necessary.

« Back to merge proposal