Code review comment for lp:~stefanor/ibid/translation-334764

Revision history for this message
Stefano Rivera (stefanor) wrote :

"Note, if you want to call addresponse with an arbitrary string, you now have to use addresponse(u'%s', string). We could work around this, by checking if len(attrs) > 0, but I think the way it is will promote good response style."

I'm having second thoughts about this:

I often forget to type the u. It's really naughty, and I should be punished, but the result is that the bot says something like "tumbleweed: Sorry, I don't know about a currency called %s", rather than doing the right thing and logging a warning. What do we prefer to do?

« Back to merge proposal