Code review comment for lp:~stefanor/launchpadlib/include-manifest

Revision history for this message
Colin Watson (cjwatson) wrote :

Dropping launchpadlib.testing from the wheel would be an API change that I'm not sure we want to do at the moment (especially since Launchpad's test suite currently relies on that in one place); I'll leave it up to you whether you do that in the Debian package, but it is intended to be useful for testing applications that use launchpadlib.

This change itself looks fine, though, thanks.

review: Approve

« Back to merge proposal