Comparing this with CopyArchiveJob shows plenty of overlap, but also
some differences given the current implementation.
- initializeFromParent eventually calls packagecloner, which
copy archives also use, so there is room for consolidation.
- i-f-p works on multiple archives at once, so ArchiveJob isn't
a direct fit, but we could create multiple jobs for i-f-p
(and there are comments in the code about whether copying partner
is the right thing to do anyway)
- copy archives always work on a distroseries, so an alternative would
be to move to DistroSeriesJob instead of ArchiveJob there, and have
archives moved in to json.
- i-f-p is really a string of jobs, with the package clone being one of
them, so perhaps breaking that method up would make sense.
I think what would help is looking at some other jobs, such as a
SyncPackagesJob and deciding what they would use, to decide if ArchiveJob,
DistroSeriesJob, or something else would make the best base.
Hi,
Comparing this with CopyArchiveJob shows plenty of overlap, but also
some differences given the current implementation.
- initializeFromP arent eventually calls packagecloner, which
copy archives also use, so there is room for consolidation.
- i-f-p works on multiple archives at once, so ArchiveJob isn't
a direct fit, but we could create multiple jobs for i-f-p
(and there are comments in the code about whether copying partner
is the right thing to do anyway)
- copy archives always work on a distroseries, so an alternative would
be to move to DistroSeriesJob instead of ArchiveJob there, and have
archives moved in to json.
- i-f-p is really a string of jobs, with the package clone being one of
them, so perhaps breaking that method up would make sense.
I think what would help is looking at some other jobs, such as a
SyncPackagesJob and deciding what they would use, to decide if ArchiveJob,
DistroSeriesJob, or something else would make the best base.
Thanks,
James