Code review comment for lp:~stevenk/launchpad/subscribers-can-view-p3as

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Thanks, good stuff.

There is only one empty line above TestPPAPackages, there should be two.

The test methods in TestP3APackages also contain the phrase p3a_packages again, this seems a bit superfluous given the test case name.

The comments on the first line of each test method explaining what the tests do could perhaps be docstrings.

review: Approve (code)

« Back to merge proposal