Code review comment for lp:~stub/launchpad/auth-mirror-tables
Revision history for this message
| Stuart Bishop (stub) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Wed, Dec 2, 2009 at 3:16 AM, Guilherme Salgado <email address hidden> wrote:
> Review: Approve release-critical
> This looks fine but I'm not really fond of maintaining a copy of the list of columns in the Person table in the update trigger. I guess there isn't much we can do about it, though?
Unfortunately, no. I have no way of doing the necessary introspection in PL/pgSQL and PL/pythonu doesn't support all the data types I need (it might work, but I didn't want to head down a possibly dead end).
> Also, we need to test this manually on staging as I guess there won't be enough time to have it rolled out as part of the next staging update.
--
Stuart Bishop <email address hidden>
http://