Launchpad itself

Code review comment for lp:~stub/launchpad/cronscripts

  1. cronscripts
  2. Merge into devel
Revision history for this message
Robert Collins (lifeless) wrote :

A few thoughts:
 - needs an os.path.abspath() around the tempfile name - /tmp is only the default, but you're making a url out of it.
 - probably want a timeout on the file grabbing.
 - if reading the file fails, perhaps we should fail-closed?

review: Approve

« Back to merge proposal