Code review comment for lp:~stub/launchpad/librarian-gc

> > + def test_deleteUnwantedFilesBug437084(self):
>
> Just looking at https://dev.launchpad.net/TestsStyleGuide#Python Test Cases
> should this be:
>
> def test_deleteUnwantedFiles_bug437084(self):
>
> or similar?

As per IRC, test_delete_unwanted_files_bug437084().

> > + # There was a bug where delete_unwanted_files() would die
> > + # if the last file found on disk was unwanted.
> > + self.layer.switchDbUser(dbuser='testadmin')
> > + content='foo'
> > + self.client.addFile(
> > + 'foo.txt', len(content), StringIO(content), 'text/plain',
> > + )
>
> I always get confused on this one, but I think you've used the tuple
> style here, rather than the multiline function call style? That is,
> I the closing ')' should be on the previous line and without the extra
> comma? See
>
> https://dev.launchpad.net/PythonStyleGuide#Multiline function calls

Yup. Copy and paste glitch. Fixed.

Thanks :)