Code review comment for lp:~stub/launchpad/memcache

<stub> henninge: https://code.edge.launchpad.net/~stub/launchpad/memcache/+merge/22849
<stub> henninge: Security issue that needs to land before the edge update (about 55 mins?)
<wgrant> stub: The branch isn't in stable yet.
<wgrant> it's fine.
<henninge> stub: looking
<wgrant> (and probably won't be until some hours after edge updates tonight)
<henninge> stub: Shouldn't that comment be an XXX that links to a bug number where the issue is tracked?
<stub> Its not a bug though.
<stub> Actually, I just realized I need to turn off caching entirely to not lose functionality, as the tooltips will continue to display old summaries when bugs are changed.
<stub> I could put a lower timeout, but that is getting really pointless.
<henninge> stub: unfortunately I am not at all familiar with caching issues ...
<henninge> stub: but this still sounds like a quick fix to me that needs further investigation to find a proper solution and we should track that in a bug in order not to forget it.
<stub> I'm not sure what the bug is. Marked up test is uncachable due to Launchpad features. We either put up with it, or change Launchpad features. Its a discussion.
<stub> I've removed the cache: stanza entirely, so the diff is just a reversal of some work that landed an hour ago and an additional comment. I can remove the comment if you like, as I think it is throughout Launchpad rather than a bug comment specific issue.
* adeuring (~<email address hidden>) hat #launchpad-reviews betreten
<henninge> stub: ok, that sounds reasonable.
<stub> henninge: Reasonable enough for an approve vote?
<henninge> stub: certainly, I was waiting for the new push ... ;-)
<henninge> stub: r=me
<stub> Ta :)