Code review comment for lp:~stub/launchpad/trivial

On Thu, Jul 23, 2009 at 08:38:44AM -0000, Stuart Bishop wrote:
> A startup script for the Librarian.
> bin/run isn't suitable for use on production as it launches an appserver.

Could it not be made to run the librarian as well? I guess at this point
whatever's easiest to do and causes less problems is sanest.

> === modified file 'Makefile'
> --- Makefile 2009-07-19 02:34:24 +0000
> +++ Makefile 2009-07-23 06:57:17 +0000
> @@ -176,6 +176,12 @@
> stop_codebrowse:
> $(PY) sourcecode/launchpad-loggerhead/stop-loggerhead.py
>
> +start_librarian: build
> + bin/start_librarian
> +
> +stop_librarian:
> + bin/killservice librarian

Are these created by buildout automatically? I haven't seen any of this
code before, sorry.

> === modified file 'lib/canonical/launchpad/scripts/runlaunchpad.py'

What else uses this script? /bin/run?

> @@ -84,7 +85,6 @@
> tacfile = make_abspath(self.tac_filename)
>
> args = [
> - sys.executable,
> TWISTD_SCRIPT,

Was this broken or just unnecessary? I can't see what this code does
from the context.

> - # We want to make sure that the Launchpad process will have the
> - # benefit # of all of the dependency paths inserted by the buildout
> - # bin/run script. We pass them via PYTHONPATH.
> - env = dict(os.environ)
> - env['PYTHONPATH'] = os.path.pathsep.join(sys.path)

Will this not cause problems anywhere else?
--
Christian Robottom Reis | [+55 16] 3376 0125 | http://launchpad.net/~kiko
                        | [+55 16] 9112 6430 | http://async.com.br/~kiko