Code review comment for lp:~stub/launchpad/update-storm

Revision history for this message
Jonathan Lange (jml) wrote :

Hey Stuart,

Thanks for debugging this problem. The changes look good, but I've got a couple of questions:

  - is there a way to avoid repeating the settings so many times over? is it desirable to do so?

  - why is one of the items changed to a cache size of 10000?

  - can you please update the storm_cache_size comment in the schema to say what units are being used?

Thanks,
jml

review: Needs Fixing

« Back to merge proposal