Code review comment for lp:~stub/launchpad/update-storm
Revision history for this message
| Stuart Bishop (stub) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Wed, Jul 22, 2009 at 2:11 PM, Jonathan Lange<email address hidden> wrote:
> Review: Needs Fixing
> Hey Stuart,
>
> Thanks for debugging this problem. The changes look good, but I've got a couple of questions:
>
> - is there a way to avoid repeating the settings so many times over? is it desirable to do so?
>
It doesn't look like it can be avoided. It is not desirable. I'm not sure if the new config machinery was implemented this way by design or by necessity. Perhaps I'm doing something wrong.
> - why is one of the items changed to a cache size of 10000?
That is the appserver. Its not being changed - it is just being moved up a bit to be consistent.
> - can you please update the storm_cache_size comment in the schema to say what units are being used?
Done.
I think I need to discuss on the Storm list how we should implement a cache that is bounded by RAM usage rather than object count.
--
Stuart Bishop <email address hidden>
http://