Code review comment for lp:~stub/launchpad/update-storm

Revision history for this message
Stuart Bishop (stub) wrote :

> >  - is there a way to avoid repeating the settings so many times over? is it
> desirable to do so?
> >
>
> It doesn't look like it can be avoided. It is not desirable. I'm not sure if
> the new config machinery was implemented this way by design or by necessity.
> Perhaps I'm doing something wrong.

I should explain this more. Without this boilerplate, the values are inherited from the [database] section but they cannot be overridden in a launchpad-lazr.conf file. I believe this is because the config parser knows nothing about how these sections inherit from the [database] section causing unknown key errors to be raised. The [database] fallback is done in lib/canonical/config and is launchpad specific.

« Back to merge proposal