Merge lp:~ted/libdbusmenu/valgrind-no-libs into lp:libdbusmenu/0.6

Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 398
Merge reported by: Charles Kerr
Merged at revision: not available
Proposed branch: lp:~ted/libdbusmenu/valgrind-no-libs
Merge into: lp:libdbusmenu/0.6
Diff against target: 28 lines (+3/-2)
2 files modified
configure.ac (+2/-2)
tests/Makefile.am (+1/-0)
To merge this branch: bzr merge lp:~ted/libdbusmenu/valgrind-no-libs
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+100423@code.launchpad.net

Description of the change

Removing the valgrind lib as it isn't needed and screws up ARM.

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

I wouldn't've expected that... lucky break :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure.ac'
--- configure.ac 2012-03-29 18:08:49 +0000
+++ configure.ac 2012-04-02 14:28:25 +0000
@@ -118,10 +118,10 @@
118118
119AS_IF([test "x$enable_tests" != "xno"],[119AS_IF([test "x$enable_tests" != "xno"],[
120PKG_CHECK_MODULES(DBUSMENUTESTS, json-glib-1.0 >= $JSON_GLIB_REQUIRED_VERSION120PKG_CHECK_MODULES(DBUSMENUTESTS, json-glib-1.0 >= $JSON_GLIB_REQUIRED_VERSION
121 gio-unix-2.0 >= $GIO_UNIX_REQUIRED_VERSION121 gio-unix-2.0 >= $GIO_UNIX_REQUIRED_VERSION,
122 valgrind,
123 [have_tests=yes]122 [have_tests=yes]
124)123)
124PKG_CHECK_MODULES(DBUSMENUTESTSVALGRIND, valgrind)
125])125])
126126
127AC_SUBST(DBUSMENUTESTS_CFLAGS)127AC_SUBST(DBUSMENUTESTS_CFLAGS)
128128
=== modified file 'tests/Makefile.am'
--- tests/Makefile.am 2012-03-29 04:30:40 +0000
+++ tests/Makefile.am 2012-04-02 14:28:25 +0000
@@ -223,6 +223,7 @@
223 -I $(srcdir) \223 -I $(srcdir) \
224 $(DBUSMENUGLIB_CFLAGS) \224 $(DBUSMENUGLIB_CFLAGS) \
225 $(DBUSMENUTESTS_CFLAGS) \225 $(DBUSMENUTESTS_CFLAGS) \
226 $(DBUSMENUTESTSVALGRIND_CFLAGS) \
226 -Wall -Werror227 -Wall -Werror
227228
228test_json_server_LDADD = \229test_json_server_LDADD = \

Subscribers

People subscribed via source and target branches

to all changes: