Code review comment for lp:~ted/libindicate/messages-v2

Revision history for this message
Aurélien Gâteau (agateau) wrote :

(I mostly reviewed the API, not much of the internal changes)

I see the server parameter has been removed from the IndicatorAdded and IndicatorRemoved signals. Does this mean the indicator id is now globally unique?

There is a missing word in doc for INDICATE_INDICATOR_SIGNAL_DISPLAYED signal

indicate_listener_default_max_indicators():
typo in doc: effects => affects
I would have called this function indicate_listener_set_default_max_indicators() for consistency

indicate_listener_server_max_indicators():
I would have called this function indicate_listener_server_set_max_indicators()

Question: do we still need the concept of Interest?

And oh, indentation is really... creative

review: Needs Information

« Back to merge proposal