(I mostly reviewed the API, not much of the internal changes)
I see the server parameter has been removed from the IndicatorAdded and IndicatorRemoved signals. Does this mean the indicator id is now globally unique?
There is a missing word in doc for INDICATE_INDICATOR_SIGNAL_DISPLAYED signal
indicate_listener_default_max_indicators():
typo in doc: effects => affects
I would have called this function indicate_listener_set_default_max_indicators() for consistency
indicate_listener_server_max_indicators():
I would have called this function indicate_listener_server_set_max_indicators()
Question: do we still need the concept of Interest?
(I mostly reviewed the API, not much of the internal changes)
I see the server parameter has been removed from the IndicatorAdded and IndicatorRemoved signals. Does this mean the indicator id is now globally unique?
There is a missing word in doc for INDICATE_ INDICATOR_ SIGNAL_ DISPLAYED signal
indicate_ listener_ default_ max_indicators( ): listener_ set_default_ max_indicators( ) for consistency
typo in doc: effects => affects
I would have called this function indicate_
indicate_ listener_ server_ max_indicators( ): listener_ server_ set_max_ indicators( )
I would have called this function indicate_
Question: do we still need the concept of Interest?
And oh, indentation is really... creative