Merge lp:~ted/ubuntu/lucid/liferea/notification-append into lp:ubuntu/lucid/liferea

Proposed by Ted Gould
Status: Merged
Merged at revision: not available
Proposed branch: lp:~ted/ubuntu/lucid/liferea/notification-append
Merge into: lp:ubuntu/lucid/liferea
Diff against target: 72 lines (+52/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/notification-append (+44/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~ted/ubuntu/lucid/liferea/notification-append
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Ubuntu branches Pending
Review via email: mp+19050@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

Notification append patch

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

modified to corresponds to trunk and merged

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-02-10 08:31:45 +0000
+++ debian/changelog 2010-02-10 20:30:42 +0000
@@ -1,3 +1,10 @@
1liferea (1.6.2-1ubuntu3) lucid; urgency=low
2
3 * debian/patches/notification-append: Add patch to make the notification
4 use the append feature of notify-osd. (LP: #457869)
5
6 -- Ted Gould <ted@ubuntu.com> Wed, 10 Feb 2010 14:16:11 -0600
7
1liferea (1.6.2-1ubuntu2) lucid; urgency=low8liferea (1.6.2-1ubuntu2) lucid; urgency=low
29
3 * debian/patches/add_X-Ubuntu-Gettext-Domain: add x-ubuntu-gettext-domain10 * debian/patches/add_X-Ubuntu-Gettext-Domain: add x-ubuntu-gettext-domain
411
=== added file 'debian/patches/notification-append'
--- debian/patches/notification-append 1970-01-01 00:00:00 +0000
+++ debian/patches/notification-append 2010-02-10 20:30:42 +0000
@@ -0,0 +1,44 @@
1diff -ur liferea-1.6.0-rc6/src/notification/libnotify.c liferea-ted/src/notification/libnotify.c
2--- liferea-1.6.0-rc6/src/notification/libnotify.c 2009-06-20 13:33:19.000000000 -0500
3+++ liferea-ted/src/notification/libnotify.c 2009-09-10 23:00:39.000000000 -0500
4@@ -44,6 +44,7 @@
5 #include "notification/notification.h"
6
7 static gboolean supports_actions = FALSE;
8+static gboolean supports_append = FALSE;
9
10 static void notif_libnotify_callback_open ( NotifyNotification *n, gchar *action, gpointer user_data ) {
11 g_assert(action != NULL);
12@@ -188,7 +189,11 @@
13 for (c = caps; c != NULL; c = c->next) {
14 if (g_str_equal ((char*)c->data, "actions")) {
15 supports_actions = TRUE;
16- break;
17+ continue;
18+ }
19+ if (g_str_equal ((char*)c->data, "append")) {
20+ supports_append = TRUE;
21+ continue;
22 }
23 }
24 g_list_foreach (caps, (GFunc)g_free, NULL);
25@@ -242,12 +247,16 @@
26 if (item_count == 0)
27 return;
28
29- labelSummary_p = g_strdup_printf (ngettext ("%s has %d new / updated headline\n", "%s has %d new / updated headlines\n", item_count),
30+ labelSummary_p = g_strdup_printf (ngettext ("<b>%s</b> has <b>%d</b> update", "<b>%s</b> has <b>%d</b> updates", item_count),
31 node_get_title (node), item_count);
32- n = notify_notification_new ( _("Feed Update"), labelSummary_p, NULL, NULL);
33+ n = notify_notification_new ( _("Feed Update"), labelSummary_p, "liferea", NULL);
34 g_free(labelSummary_p);
35
36- notify_notification_set_icon_from_pixbuf (n, node_get_icon (node));
37+ if (supports_append) {
38+ notify_notification_set_hint_string(n, "append", "allow");
39+ } else {
40+ notify_notification_set_icon_from_pixbuf (n, node_get_icon (node));
41+ }
42 notify_notification_set_timeout (n, NOTIFY_EXPIRES_DEFAULT);
43 if (supports_actions) {
44 notify_notification_add_action (n, "show_details", _("Show details"),
045
=== modified file 'debian/patches/series'
--- debian/patches/series 2010-02-10 08:31:45 +0000
+++ debian/patches/series 2010-02-10 20:30:42 +0000
@@ -7,3 +7,4 @@
701_ubuntu_feedlists701_ubuntu_feedlists
8fix_systray_behavior8fix_systray_behavior
9add_X-Ubuntu-Gettext-Domain9add_X-Ubuntu-Gettext-Domain
10notification-append

Subscribers

People subscribed via source and target branches

to all changes: