Code review comment for lp:~ted/url-dispatcher/de-upstart

Revision history for this message
dobey (dobey) wrote :

21:59:22 /<<BUILDDIR>>/url-dispatcher-0.1+17.04.20170314+fetch1805bzr114/tests/dispatcher-test.cc:329:2: required from here
21:59:22 /<<BUILDDIR>>/url-dispatcher-0.1+17.04.20170314+fetch1805bzr114/tests/dispatcher-test.cc:331:2: required from here
21:59:22 /<<BUILDDIR>>/url-dispatcher-0.1+17.04.20170314+fetch1805bzr114/tests/dispatcher-test.cc:343:2: required from here

21:59:25 /<<BUILDDIR>>/url-dispatcher-0.1+17.04.20170314+fetch1805bzr114/tests/lib-test.cc:98:2: required from here
21:59:25 /<<BUILDDIR>>/url-dispatcher-0.1+17.04.20170314+fetch1805bzr114/tests/lib-test.cc:148:2: required from here

21:58:57 /<<BUILDDIR>>/url-dispatcher-0.1+17.04.20170314+fetch1805bzr114/tests/url-db-test.cc:169:2: required from here

21:59:15 /<<BUILDDIR>>/url-dispatcher-0.1+17.04.20170314+fetch1805bzr114/tests/exec-tool-test.cc:106:2: required from here

21:59:22 /usr/src/googletest/googletest/include/gtest/gtest.h:1392:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

review: Needs Fixing

« Back to merge proposal