Code review comment for lp:~terrycojones/txamqp/lots-of-comments

Revision history for this message
Thomas Herve (therve) wrote :

[1] The link to the blog post is broken, mainly you should remove it.

[2]
+ $ bzr branch lp:txamqp txamqp

"bzr branch lp:txamqp" is enough to work.

[3]
+ - path_to_spec: The path to the AMQP spec that you want to use. Note
+ that depending on the broker you use, you will need a
+ different spec:
+ RabbitMQ 1.5.3: $TXAMQP_PATH/src/specs/standard/amqp0-8.xml

I think this path changed.

[4]
-# coding: utf-8
+# -*- coding: utf-8; -*-

We don't really need those as the files are pure ASCII afaict.

[5]
+ """A class that acts like an event that can be fired (via set). This is

+ """Call the init method (if any) in all superclasses of the subclass of

Can you break the line at the beginning?

[6]
+ the delegate (see TwistedDelegate in client.py) to make the appropriate
+ method call."""

And at the end? :)

[7] There are a bunch of conflicts, mostly trivial.

Thanks, +1!

review: Approve

« Back to merge proposal