Code review comment for lp:~thekorn/launchpadlib/fix-342709-ensure-representation
Revision history for this message
| Leonard Richardson (leonardr) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
My initial reaction was that this undid an optimization. If we automatically retrieved representations we'd be making all kinds of unnecessary requests.
But actually, this is fine. We only make the request when (eg.) dir() is called on an object that doesn't have a representation. If you never call dir() this code will never run. So I think this is a good patch.