Code review comment for lp:~thekorn/wadllib/fix-340935-use-actual-type

Revision history for this message
Leonard Richardson (leonardr) wrote :

Unfortunately this branch makes the Launchpad-specific assumption that the resource type is kept in "resource_type_link". Launchpad-specific assumptions must go in launchpadlib so that wadllib can stay generic.

I can see a setup where wadllib calls a hook method and passes in the processed representation, and launchpadlib acts as an oracle to determine what the resource type is. Unfortunately I don't have time to do the design in more detail than that.

review: Disapprove

« Back to merge proposal